ok2c commented on PR #555: URL: https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002636234
> 1. While keeping the `PoolingHttpClientConnectionManager` constructor internal, should I add a way to provide a custom `HttpClientConnectionOperator` to the `PoolingHttpClientConnectionManager`? > @tippl Do you mean `PoolingHttpClientConnectionManager` builder? if so, I would rather not couple it with an internal interface.. > 2. The `DefaultAsyncClientConnectionOperator` is final, i'll open it up to extending. > Sure. > 3. There is no "easy" way at least from first look to hook around DNS resolution in the `DefaultAsyncClientConnectionOperator`, since that is inside of the `MultihomeIOSessionRequester`. But you can work around that by implementing your own `DnsResolver` and have that handle metrics, so I'll remove the callbacks for DNS. > Sure thing. Makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org