tippl commented on PR #555: URL: https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002643664
> @tippl Do you mean `PoolingHttpClientConnectionManager` builder? if so, I would rather not couple it with an internal interface.. @ok2c As it stands now, ignoring the deprecated constructors of `PoolingHttpClientConnectionManager`, it only has a default constructor with no parameters and 2 "internal" protected constructors that allow you to set a `HttpClientConnectionOperator`. (these are already used by the builder) So there is no way to actually create a `PoolingHttpClientConnectionManager` with a custom `HttpClientConnectionOperator`, either by itself or through the Builder. In the mail thread, you suggested making the protected constructor public, but I feel rather adding `HttpClientConnectionOperator` to the builder and keeping the internal constructors as they are without changing the visibility. Since besides the absolute basic default constructor, the intent seems to be to mainly create it through the builder. So if you specify a `HttpClientConnectionOperator` in the builder, that is used, otherwise a default is created. This feels like a better solution than having to extend/reimplement parts of the `PoolingHttpClientConnectionManager` along with the builder to be able to use it with a custom Operator. This is what i meant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
