ok2c commented on code in PR #721:
URL: 
https://github.com/apache/httpcomponents-client/pull/721#discussion_r2345334121


##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AbstractHttpAsyncClientBase.java:
##########
@@ -116,7 +116,7 @@ public final void close(final CloseMode closeMode) {
         }
         ioReactor.initiateShutdown();
         ioReactor.close(closeMode);
-        executorService.shutdownNow();
+        executorService.shutdown();

Review Comment:
   @koszta5 I am currently crushed with my day work and a major HTTP/2 rewrite 
in core. Please do put a comment in the original JIRA ticket about the 
`CloseMode` flag and will try to get around to fixing the problem sometime next 
week.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to