ok2c commented on code in PR #721:
URL:
https://github.com/apache/httpcomponents-client/pull/721#discussion_r2345091333
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AbstractHttpAsyncClientBase.java:
##########
@@ -116,7 +116,7 @@ public final void close(final CloseMode closeMode) {
}
ioReactor.initiateShutdown();
ioReactor.close(closeMode);
- executorService.shutdownNow();
+ executorService.shutdown();
Review Comment:
@koszta5 I am very tempted to close the ticket as invalid right now and move
onto other things, but in case I have trouble understanding written English,
here is what the ticket says:
```
* The AutoShutdownDelegatedExecutorService correctly calls the shutdownNow()
method on the underlying executor service.
* However, the phantom reference is never dereferenced and remains held
internally.
```
What is `AutoShutdownDelegatedExecutorService` exactly and why does not it
de-references the the phantom reference with `#shutdownNow`? How is this
exactly a problem with HttpClient? Please help me understand if you expect me
to merge this change-set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
