koszta5 commented on code in PR #721:
URL:
https://github.com/apache/httpcomponents-client/pull/721#discussion_r2345055249
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AbstractHttpAsyncClientBase.java:
##########
@@ -116,7 +116,7 @@ public final void close(final CloseMode closeMode) {
}
ioReactor.initiateShutdown();
ioReactor.close(closeMode);
- executorService.shutdownNow();
+ executorService.shutdown();
Review Comment:
please - read the jira ticket description
(https://issues.apache.org/jira/browse/HTTPCLIENT-2391). Due to implementation
of the ThreadPool (AutoShutdownDelegatedExecutorService) shutdownNow() does
not remove a phantom reference to the delegated thread pool
Shutdown does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
