On Mon, 2002-05-27 at 05:51, Joe Orton wrote:
> On Mon, May 27, 2002 at 08:02:13AM -0400, Joshua Slive wrote:
> > Joe Orton wrote:
> > > Currently config directory processing isn't very useful in practice
> > > because all files in the config dir are loaded - so if you use an editor
> > > which creates backup files, the backup file will still be loaded.
> > > 
> > > A simple way to fix this is to only load files in the config dir which
> > > match the pattern "[A-Za-z0-9]*.conf", as in the following patch (which
> > > also removes the noise produced on stderr when processing config dirs)
> > 
> > Fine, but I still prefer my solution: allow the user to supply the 
> > fnmatch, so that they could just do
> > Include *.conf
> > or
> > Include *.whatever
> > or
> > Include File??.conf
> > etc.
> 
> I agree that would be better, but it would really require a glob()
> function to implement properly; I don't know how portable that is.

As a compromise solution, how about:

  * Implement user-defined patterns for now, using apr_fnmatch(), but
    restrict the patterns to matching a single directory (so that we
    only need fnmatch and not full glob support).
  * Later, add a more general glob() function in APR, and retrofit it
    into the httpd config processing so that people can do things like
    "Include local/*/*.conf"

--Brian


Reply via email to