Brad Nicholes wrote:
I'm not sure what you are asking. I haven't proposed any of my recent changes for backport yet because of the changes required in include/util_ldap.h. Since util_ldap.h can be considered a public header, technically any changes to the structure would require an MMN bump. But the question is since mod_auth_ldap and mod_ldap are still experimental, do the rules still apply. Being experimental modules would imply that changes like this could happen without notice. On a different but related issue. I still don't understand why util_ldap.h is in the /include directory. There is nothing in it that directly relates to anything in httpd itself. Without mod_ldap (aka. util_ldap) loaded, it makes no sense on its own. It simply defines all of the APIs and structures that are part of mod_ldap. If util_ldap.h were to move from /include to /experimental (for now) along side of the other util_ldap code, that would eliminate the MMN bump issue, right?
Modules (right now, only mod_auth_ldap) depend on util_ldap, and changing the header would mean a break in binary compatibility (in theory). I think we should probably stick with an MMN bump for this to be consistent, even though only the mod_auth_ldap module uses it (to my knowledge).
As for the header being in /include, I think it should be there so that external modules can be built against util_ldap. If the header was in /experiemental, the full httpd source would be needed to build an Apache module that used util_ldap (unless I am misunderstanding something).
Regards, Graham --
