Pier Fumagalli wrote:
I don't understand why mod_cache forcedly avoids caching URLs ending with the "/" (slash) character.
Apparently EGP (who's he?) agrees.
Anyhow, it's several months that we're running with this patch in production, and nothing bad seems to be happening.
Pier
diff -U3 -wr httpd-2.0.50-orig/modules/experimental/mod_cache.c httpd-2.0.50/modules/experimental/mod_cache.c
--- httpd-2.0.50-orig/modules/experimental/mod_cache.c
+++ httpd-2.0.50/modules/experimental/mod_cache.c
@@ -79,10 +79,6 @@
"cache: URL exceeds length threshold: %s", url);
return DECLINED;
}
- /* DECLINE urls ending in / ??? EGP: why? */
- if (url[urllen-1] == '/') {
- return DECLINED;
- }
/* make space for the per request config */ cache = (cache_request_rec *) ap_get_module_config(r->request_config,
I played with this and like has already been pointed out, when mod_dir is loaded, the url is still not cached. So the question to answer is this... if mod_cache -and- mod_dir are enabled, does this patch cause any undesirable side effects? If the answer is no, then +1 on the patch.
Bill
