On Thu, Jan 8, 2015 at 6:08 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > On Thu, Jan 8, 2015 at 5:29 PM, Ewald Dieterich <ew...@mailbox.org> wrote: >> >> Looks good. I tested both your patch and my modified one and now error >> response and access log entry are both OK. > > Thanks Ewald for testing. > > Eric, all proxy modules concerned in trunk could be fixed with > "(status == AP_FILTER_ERROR) ? DONE : > ap_map_http_request_error(status, HTTP_BAD_REQUEST)", but not 2.4.x > where "(status == AP_FILTER_ERROR) ? DONE : HTTP_BAD_REQUEST)" is a > simple fix. > Should we also (propose to )backport to 2.4.x the whole > ap_map_http_request_error() stuff (r1482522 + r1529991 + r1482918, > quite huge...) so that we don't lose specific errors returned by > ap_http_filter (ie. turned to 400), or is the simple fix OK?
Also, it seems that ap_map_http_request_error() would better map AP_FILTER_ERROR to DONE, any issue with this?
