On Thu, Jan 8, 2015 at 6:17 PM, Eric Covener <[email protected]> wrote: > On Thu, Jan 8, 2015 at 12:12 PM, Yann Ylavic <[email protected]> wrote: >> Also, it seems that ap_map_http_request_error() would better map >> AP_FILTER_ERROR to DONE, any issue with this? > > Does that affect ap_die adversely? It can no longer tell the difference.
As we already discussed in [1] and [2], we'd probably handle AP_FILTER better in ap_die() and apply patch [3], so that we don't have to bother whether a handler returns DONE or AP_FILTER_ERROR, ap_die() should do the right thing (ie. nothing if AP_FILTER_ERROR already generated a response). [1] http://mail-archives.apache.org/mod_mbox/httpd-dev/201401.mbox/%3CCALK=YjMb2DHo415PuAt4_DsBjXFsvB-ag=qjixx6uclhn62...@mail.gmail.com%3E [2] http://issues.apache.org/bugzilla/show_bug.cgi?id=56035 [3] http://issues.apache.org/bugzilla/attachment.cgi?id=31245
