On Sat, Oct 24, 2015 at 10:49 AM, Jim Jagielski <j...@jagunet.com> wrote:
> Just some food for thought; let me know if I'm off the rails. > Well, that depends on what you are commenting on... Over the last several months, it's appeared to me that we have > been adding patches that feel, well, very-patchy to me. They > feel like cumbersome add-ons that create some level of fragility > to our code, with special one-off considerations instead of a > deeper more complete fix. In other words, it seems that httpd is > becoming more crufty rather than planned and cohesive and > consistent. > So over an arbitrary window of time (several months = 12 weeks?) there are patches that you are uncomfortable with on trunk? 2.4? Perhaps even 2.2? They seem to be fingers in the dam, rather than reinforcing the wall of a solid code base? Rather than 'vaugebooking' (to borrow a phrase from another context), it might be helpful to point out the specific commits that have you concerned, and register specific complaints or feedback? If a -1 is called for, of course put that forward, but perhaps some coaching/coaxing might get the specific fixes into the sort of shape you feel is appropriate? If there is a pattern from specific committers, pointing out any issues on one patch is probably sufficient to coax them into reviewing their other patches for similar issues and avoid any similar issues in the future? Some parts of trunk are certainly due for refactoring, but that can be a multi-week task rather than the obvious quick fix. If there is a better or more comprehensive fix, calling it out on the list might solicit rework from yet another committer who is interested in the same issue at hand? As a committer and PMC member, it is yours, and mine, and all the rest of the project participants to point out problematic commits individually. That's the definition of commit-then-review, something you recently championed an expansion of for more aspects of the 2.4 branch. Please pipe up on the -r phase so we all learn which patches concerns you, and why?
