Wow! Nice work!
> Am 21.02.2018 um 21:34 schrieb Rainer Jung <rainer.j...@kippdata.de>:
>
> Am 19.02.2018 um 15:54 schrieb drugg...@primary.net:
>> Hi, all;
>> Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>> I would like to call a VOTE over the next few days to release this candidate
>> tarball as 2.4.30:
>> [ ] +1: It’s not just good, it’s good enough!
>> [ ] +0: Let’s have a talk…
>> [ ] -1: There’s trouble in paradise. Here’s what’s wrong.
>
> -1 to release due to the flaws found by others. But we should be good with
> 2.4.31. Please update APR/APU in the deps tarball.
>
> Detailed report:
>
> - Sigs and hashes OK
> - contents of tarballs identical
> - contents of tag and tarballs identical
> except for expected deltas
> - deps convenience tarball does not contain latest APR/APU 1.6.3/1.6.1
> -> please update
>
> Built on
>
> - Solaris 10 Sparc as 32 Bit Binaries
> - SLES 11+12 (64 Bits)
> - RHEL 6+7 (64 Bits)
>
> For all platforms built
>
> - with default (shared) and static modules
> - with module set reallyall
> - using --enable-load-all-modules
> - against "included" APR/APU from deps tarball,
> plus external APR/APU 1.6.3/1.6.1 and 1.5.2/1.5.4
>
> - using external libraries
> - expat 2.2.5
> - pcre 8.41
> - openssl 1.0.2n plus patches
> - lua 5.3.4 (compiled with LUA_COMPAT_MODULE)
> - distcache 1.5.1
> - libxml2 2.9.7
> - libnghttp2 1.30.0
> - brotli 1.0.2
> - curl 7.58.0
> - jansson 2.10
>
> - Tool chain:
> - platform gcc except on Solaris
> (gcc 7.3.0 Solaris 10, only older APR/APU 1.5.x compiled with older gcc
> 4.9.2)
> - CFLAGS: -O2 -g -Wall -fno-strict-aliasing
> - on Solaris additionally -mpcu=v9, -D_XOPEN_SOURCE,
> -D_XOPEN_SOURCE_EXTENDED=1, -D__EXTENSIONS__
> and -D_XPG6
>
> All 40 builds succeeded.
>
> - compiler warnings:
>
> - modules/core/mod_watchdog.c:436: warning: 'rv' may be used
> uninitialized in this function
> -> warning is correct but not critical (debug log);
> not a regression
>
> on RHEL 6 and SLES 11 due to older GCC versions:
>
> - modules/md/md_json.c:31: warning: expected [error|warning|ignored] after
> '#pragma GCC diagnostic'
>
> - modules/md/md_json.c:45: warning: expected [error|warning|ignored] after
> '#pragma GCC diagnostic'
>
> due to strange jansson dependency library header files:
>
> include/jansson.h:117:6: warning: 'json_decrefp' defined but not used
> [-Wunused-function]
> include/jansson.h:187:5: warning: 'json_object_set_nocheck' defined but not
> used [-Wunused-function]
> include/jansson.h:193:5: warning: 'json_object_iter_set' defined but not used
> [-Wunused-function]
> include/jansson.h:208:5: warning: 'json_array_set' defined but not used
> [-Wunused-function]
> include/jansson.h:220:5: warning: 'json_array_insert' defined but not used
> [-Wunused-function]
>
> and only on Solaris (gcc 7.3.0)
>
> - modules/ldap/util_ldap_cache_mgr.c:728:32: warning: format '%ld' expects
> argument of type 'long int', but argument 6 has type 'long long int'
> [-Wformat=]
>
> - modules/ldap/util_ldap_cache.c:111:20: warning: format '%ld' expects
> argument of type 'long int', but argument 8 has type 'long long int'
> [-Wformat=]
>
> - srclib/apr-util/xlate/xlate.c:120:38: warning: passing argument 2 of
> 'iconv' from incompatible pointer type
> [-Wincompatible-pointer-types]
>
> - srclib/apr-util/xlate/xlate.c:343:42: warning: passing argument 2 of
> 'iconv' from incompatible pointer type
> [-Wincompatible-pointer-types]
>
>
> Tested for
>
> - Solaris 10, SLES 11+12, RHEL 6+7
> - MPMs prefork, worker, event
> - default and static modules
> - log levels info, debug and trace8
> - module set reallyall (127 modules plus MPMs)
>
> The following test failures were seen:
>
> a Lots of tests in t/module/session.t fail always for static builds.
> Not a regression.
> For 2.4.28 the analysis was:
> The whole setup for the /sessiontest uri is missing in the generated
> t/conf/httpd.conf. This is due to it missing from the also generated
> filet/conf/apache_test_config.pm. I do not know yet, why it is missing
> there, but this seems to be a test framework problem.
>
> b Test 59 of t/modules/include.t only and always on
> Solaris.
> Not a regression
> Old analysis was:
> This is due to a bug in the test, which uses strftime()
> with a "%s" pattern that is not supported on Solaris.
> Until recently the server and the test client both returned
> verbatim "%s" and the test succeeded. After updating some
> Perl modules for the http2 tests, the perl client even
> on Solaris now supports "%s" in strftime and the test starts
> to fail. It seems we have to fix the test.
>
> c Various tests in t/apache/expr_string.t
> Not a regression.
> Test numbers : 6, 11, 14, 17, 20, 23, 26, 29
> Happens for 9 out of about 225 runs (8 times on RHEL6, once
> on Solaris).
> The failure is almost always on line 87, where the error_log contents
> are checked.
>
> d One single test run (RHEL 7) failed test 163 of t/ssl/proxy.t
> (line 131 of Apache-Test/lib/Apache/TestCommonPost.pm)
>
> e Only on Solaris and only with prefork proxy tests sometimes
> seem to hang until timeout.
> Not a regression
> Some test runs complete without
> Not observed for static builds. Only builds based on APR/APU 1.6.x
> seem to have the problem. First observed when testing 2.4.26.
> It seems processes die due to Solaris mutex deadlock detection
> for the accept mutex (false positive). Such processes get not
> replaced until we end up with only one prefork child, which of
> course can't serve proxy requests.
>
> All in all I don't see a critical problem during my tests.
>
> Regards,
>
> Rainer
