Hi Ivan, provided that committer has installed ignite-abbrev-plugin it is not a big deal to abbreviate common words before a merge.
I had the same impression about abbreviations when I came to the project: "all other development world tends to expose as much meaning as it is humanly possible in code, but Ignite has abbreviations seemed to hide this meaning". But later I've used to most common abbreviations, like ctx, and I always understand that this implies context. Sincerely, Dmitriy Pavlov пт, 2 нояб. 2018 г. в 10:21, Andrey Kuznetsov <stku...@gmail.com>: > Ivan, I agree with you: some our code style rules are really uncommon. > > As for one-time contributions, if somebody decides to make a contribution > to some project, it's ok to adopt that project rules. Moreover, reviewing > committer can silently fix minor code style issues himself upon merge. > > пт, 2 нояб. 2018 г. в 10:08, Павлухин Иван <vololo...@gmail.com>: > > > Andrey, Yakov, > > > > Actually my concert is more about one-time contributions. I imagine > > the following. Someone finds a bug a decides to contribute a fix. > > I think it is quite common scenario in Open Source. > > He creates a PR and awaits a review. I think that a smooth and fast > > review process will encourage for new contributions. But if the review > > process is not such the contributor can simply give up. > > > > P.S. In my mind there are quite uncommon code style rules in Ignite > > project. But it is definitely not for that topic. I imagine some "New > > Contributor Survey". > > > > чт, 1 нояб. 2018 г. в 18:28, Yakov Zhdanov <yzhda...@apache.org>: > > > > > Ivan I removed "lic" from the list. Thanks for catch! > > > > > > Agree with Andrey. After several code reviews newcomers will get used > to > > > abbreviations. > > > > > > Andrey, try searching for "fut" and make sure to have "Word" checked. > You > > > will see plenty of usages. "f" is also ok for future in case it does > not > > > bring confusion and does not hurt readability. > > > > > > Let's keep using abbreviations and treat them as mandatory requirement. > > > This is important for keeping our codebase consistent and tidy. > > > > > > --Yakov > > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > > > > -- > Best regards, > Andrey Kuznetsov. >
