Hi,

> I also added the license in Apache Hive to the class header with a notice 
> "Based on *.java from Apache Hive", just as Spark does in 
> 
> https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java

Take care in copying what TLP project do (especially Spark) as it may be 
incorrect or out of date. What changes have been made to that file? In general 
significant changes need to have been made in order for the header to change. 
[1] Ask yourself is the statement "Licensed to the Apache Software Foundation 
(ASF) under one or more contributor license agreements.” actually true for that 
file?

Now you may need to include what in Hive NOTICE file in your NOTICE file. 
Looking at it [2] I’m horrified to find "This project includes software 
licensed under the JSON license.” which is a category X and can’t be included 
in an ASF project.

> These are some dependencies seem to be used by the Maven build and not the 
> built software. This usually isn't mentioned in LICENSE files.
> 
> I have removed these references in the license file.

Correct only software bundled in the release needs to be mentioned, 
dependancies should not be mentioned in LICENSE.

Thanks,
Justin

1. https://www.apache.org/legal/src-headers.html#3party
2. https://github.com/apache/hive/blob/master/NOTICE

Reply via email to