Hi, > Take care in copying what TLP project do (especially Spark) as it may be > incorrect or out of date. What changes have been made to that file? In > general significant changes need to have been made in order for the header to > change. [1] Ask yourself is the statement "Licensed to the Apache Software > Foundation (ASF) under one or more contributor license agreements.” actually > true for that file?
In the PR, the new file header is: /** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ /** * Based on ASTErrorNode.java from Apache Hive * * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ Are the second paragraph and the "Based on ASTErrorNode.java from Apache Hive" needed? If not, I will remove them. Thanks. -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院
