Hi,

-1 (binding)

Major bug: The version printed in client is still 0.8.0

Others are all ok, I checked:

Binary release:
has NOTICE, LICENSE and DISCLAIMER
Start server ok
Start client ok
compatible with 0.8.0, both client-0.8.1 with server-0.8.0 and client-0.8.0 
with server-0.8.1
Example statement see below:

```
SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=FLOAT, ENCODING=RLE;
insert into root.turbine.d1(timestamp,s0) values(1,24.5);
```

Source release:
has NOTICE, LICENSE and DISCLAIMER
mvn clean package

Thanks,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "Christofer Dutz" <christofer.d...@c-ware.de>
> 发送时间: 2019-09-28 21:47:51 (星期六)
> 收件人: "dev@iotdb.apache.org" <dev@iotdb.apache.org>
> 抄送: 
> 主题: Re: [VOTE] Apache IoTDB 0.8.1 (incubating) RC1
> 
> +1 (binding) 
> However with some minor findings see below.
> 
> Please also automatically carry forward this +1 to the incubator voting
> 
> In preparation I went to the KEYS file and searched for the latest entry, 
> copied the fingerprint of that key and searched for it with my PGP tool. I 
> found the key and imported it. The email address reported matched the one I 
> expected.
> 
> - Validated the SHA512 checksums: OK
> - Validated the PGP signature: OK (However there is no established trust 
> chain to any other Apache ... actually to no-one ... @Xiangdong you really 
> should go to one of the Key-Signing-Events and have your key signed by other 
> Apaches)
> - LICENSE, NOTICE, README, RELEASE_NOTES exist: OK
> - Checked contents of LICENSE, NOTICE, README, RELEASE_NOTES: OK
> - Build IoTDB Server according to information in README.md: OK
> - Running IoTDB Server according to information in README.md: MINOR (I am 
> using OpenJDK 13 and I get an error message that IoTDB only runs on Java 8 
> and 11 ... this sort of contradicts the README which states X >= 1.8)
> - Running IoTDB Server with OpenJDK 11.0.2: OK
> - Build IoTDB Client according to information in README.md: OK
> - Running IoTDB Client according to information in README.md: OK
> - Running a full maven build with all tests (mvn clean install): OK
> - RAT didn’t report anything concerning (All binary files are image files): 
> OK (I would suggest to add an Apache Header to the ".checkstyle" XML file)
>  - It seems the Hadoop module still contains SNAPSHOT versions: MINOR
> - Binary distribution unpacks: OK
> - Able to run the server and client: MINOR (Same finding as with the source 
> distribution ... not able to run with OpenJDK 13)
> - Binary distribution contains: NOTICE and LICENSE that mention additional 
> elements of the binary distribution: OK
> 
> 
> 
> 
> 
> Am 28.09.19, 07:43 schrieb "Xiangdong Huang" <saint...@gmail.com>:
> 
>     Hi all,
>     
>     First, thanks to all of you for the support. This is my first time to be 
> as
>     a RM of Apache project and I want to thank all guys. It's because all of
>     you are so patient to answer my question that I can do this release.
>     Special thanks go to our Mentors, our committers, and a lot of documents
>     from PLC4X, Apache, Spark, etc..
>     
>     Apache IoTDB (incubating) 0.8.1 is a bug-fix version from 0.8.0. You can
>     get its mainly changes from [5].
>     
>     Apache IoTDB (Incubating) 0.8.1 has been staged under [2] and it’s time to
>     vote
>     on accepting it for release.  All Maven artifacts are available under [1].
>     If approved we will seek final release approval from the IPMC.
>     Voting will be open for 72hr.
>     
>     A minimum of 3 binding +1 votes and more binding +1 than binding -1
>     are required to pass.
>     
>     Release tag: release/0.8.1
>     Hash for the release tag: b664e8778d1221c4eb92205411e58c392214b3ab
>     
>     Per [3] "Before voting +1 PMC/PPMC members are required to download
>     the signed source code package, compile it as provided, and test
>     the resulting executable on their own platform, along with also
>     verifying that the package meets the requirements of the ASF policy
>     on releases."
>     
>     You can achieve the above by following [4].
>     
>     [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM
>     items in [4])
>     [ ]  -1 reject (explanation required)
>     
>     [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1004
>     [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.1/rc1
>     [3] https://www.apache.org/dev/release.html#approving-a-release
>     [4]
>     
> https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
>     [5]
>     https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.8.1/rc1/README.md
>     
>     Best,
>     ----------------------------------
>     Xiangdong Huang
>     School of Software, Tsinghua University
>     
>      黄向东
>     清华大学 软件学院
>     
> 

Reply via email to