reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505586923


##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ManyChildrenIT.java:
##########
@@ -82,7 +80,7 @@ public void addRemoveNodes() throws Exception {
     }
 
     @Test
-    @Ignore //OAK-10646
+    // @Ignore //OAK-10646

Review Comment:
   ```suggestion
   
   ```



##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java:
##########
@@ -977,6 +978,16 @@ public static boolean isThrottlingEnabled(final 
DocumentNodeStoreBuilder<?> buil
         return builder.isThrottlingEnabled() || (docStoreThrottlingFeature != 
null && docStoreThrottlingFeature.isEnabled());
     }
 
+    /**
+     * Check whether childOrder cleanup is enabled or not for document store.
+     *
+     * @param nodeStore instance for DocumentNodeStore
+     * @return true if childOrder cleanup is enabled else false
+     */
+    public static boolean isChildOrderCleanupEnabled(final DocumentNodeStore 
nodeStore) {
+        return nodeStore.isChildOrderCleanupFeatureEnabled();
+    }

Review Comment:
   do we need this in Utils?



##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ManyChildrenIT.java:
##########
@@ -121,10 +118,9 @@ public void moveOrderableWithManyChildren() throws 
Exception {
     }
 
     @Test
-    @Ignore //OAK-10646
+    // @Ignore //OAK-10646

Review Comment:
   ```suggestion
   
   ```



##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ManyChildrenIT.java:
##########
@@ -98,10 +96,9 @@ public void orderableAddManyChildrenWithSave() throws 
Exception {
     }
 
     @Test
-    @Ignore //OAK-10646
+    // @Ignore //OAK-10646

Review Comment:
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to