reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506016539
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -869,6 +872,11 @@ public int getMemory() {
}
}
+
+ public boolean isChildOrderCleanupEnabled() {
+ return noChildOrderCleanupFeature == null ||
!noChildOrderCleanupFeature.isEnabled();
Review Comment:
Hmmm; in that case we'd need to either disable the new tests, or change the
toggle just for those. Which would mean that we'd be testing something that
wouldn't be enabled by default. That sounds likes asking for trouble.
This is a bug fix, not a ew feature, and the toggle really is a safety net
in case something is wrong. Thus I would leave the default set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
