rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506056762
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -869,6 +872,11 @@ public int getMemory() {
}
}
+
+ public boolean isChildOrderCleanupEnabled() {
+ return noChildOrderCleanupFeature == null ||
!noChildOrderCleanupFeature.isEnabled();
Review Comment:
I agree with @stefan-egli that the default should be `false`. In the case of
tests, we can either use an OSGi config or system property (I would prefer OSGI
config) and get it overridden via reflection.
We use the same mechanism for our feature toggle i.e. a combination of both
feature toggle & OSGI config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
