[
https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707434#comment-13707434
]
Guozhang Wang commented on KAFKA-347:
-------------------------------------
A few comments:
1. In addPartitions function, we can set partitionStartIndex as the last
partition of the partition instead of partition 0 of the topic, since by doing
so as more and more of this function gets called, the broker owning partition
0's leader will have more leader partitions assigned to it.
2. Some of the changes in ZookeeperConsumerConnector for KAFKA-969 is also
included in the patch. Better trim them out for this patch.
3. Are there two getManualReplicaAssignment in AddPartitionsCommand and
CreateTopicCommand with one parameter difference? If yes could we combine them
into one?
Some minor stuff:
1. In AdminUtils, there are two more space indents for line of
"ZkUtils.updatePersistentPath(zkClient, zkPath, jsonPartitionData)"
2. In createOrUpdateTopicPartitionAssignmentPathInZK, use
if {
//
} else {
//
}
> change number of partitions of a topic online
> ---------------------------------------------
>
> Key: KAFKA-347
> URL: https://issues.apache.org/jira/browse/KAFKA-347
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Sriram Subramanian
> Labels: features
> Fix For: 0.8.1
>
> Attachments: kafka-347.patch
>
>
> We will need an admin tool to change the number of partitions of a topic
> online.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
