[
https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715392#comment-13715392
]
Jun Rao commented on KAFKA-347:
-------------------------------
Thanks for patch v2. Looks good overall. Some comments.
20. AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK(): The info
logging should be different, depending on whether the topic is created or
updated. Also, fix the indentation in the else clause.
21. AddPartitionsCommand:
21.1 remove unused imports
21.2 Is there any value in having the "replica" option? It seems that it should
always be the existing replication factor.
21.3 For the "replica-assignment-list" option, could we make it clear in the
description that this is for newly added partitions.
21.4 getManualReplicaAssignment(): We need to make sure the replica factor is
the same as the existing one.
22. KafkaController.onNewTopicCreation(): Could you explain why the
onNewPartition statement is moved to before the watcher registration? Normally,
in order not to miss any watchers, one needs to register the watcher before
reading the associated nodes in ZK.
23. PartitionStateMachine.AddPartitionsListener.handleDataChange():
23.1 In the following statement, we are actually returning all replica
assignments.
val addedPartitionReplicaAssignment =
ZkUtils.getReplicaAssignmentForTopics(zkClient, List(topic))
23.2 Instead of using controllerContext.partitionLeadershipInfo to filter out
existing partitions, it's probably better to use
controllerContext.partitionReplicaAssignment, since leaders may not always
exist.
23.3 In the error logging, could we add the affected data path?
24. AddPartitionsTest: remove unused imports
25. Did we do any test to make sure that existing consumers can pick up the new
partitions?
26. The patch needs to be rebased.
> change number of partitions of a topic online
> ---------------------------------------------
>
> Key: KAFKA-347
> URL: https://issues.apache.org/jira/browse/KAFKA-347
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Sriram Subramanian
> Labels: features
> Fix For: 0.8.1
>
> Attachments: kafka-347.patch, kafka-347-v2.patch,
> KAFKA-347-v2-rebased.patch
>
>
> We will need an admin tool to change the number of partitions of a topic
> online.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
