[
https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713864#comment-13713864
]
Neha Narkhede commented on KAFKA-347:
-------------------------------------
Overall, this looks great and sorry for not coming to this patch earlier. Few
minor comments -
1. KafkaController
1.1 We can read the list of all topics from cache instead of reading from
zookeeper, since initializeControllerContext already does that
1.2 In onNewTopicCreation, what was the motivation to move
onNewPartitionCreation to before the registration of the listener
2. PartitionStateMachine.AddPartitionsListener
controllerContext.partitionReplicaAssignment gets populated during the
NewPartition state transition.
Due to this, it is best to get rid of the following in the listener, it should
happen as part of the NewPartition state change
controllerContext.partitionReplicaAssignment.++=(partitionsRemainingToBeAdded)
3. AdminUtils
In createOrUpdateTopicPartitionAssignmentPathInZK, please change topic creation
-> Topic creation
4. There is a conflict in ZookeeperConsumerConnector
> change number of partitions of a topic online
> ---------------------------------------------
>
> Key: KAFKA-347
> URL: https://issues.apache.org/jira/browse/KAFKA-347
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Sriram Subramanian
> Labels: features
> Fix For: 0.8.1
>
> Attachments: kafka-347.patch
>
>
> We will need an admin tool to change the number of partitions of a topic
> online.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
