[
https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714259#comment-13714259
]
Joel Koshy commented on KAFKA-347:
----------------------------------
Thanks for patch v2. I'm +1 on this as is, but if you can address some of these
minor comments that would be great.
v2.1 - For "num partitions to add" vs "partitions desired" - all I meant was
that most of the time users would think
of "desired number of partitions" vs "how many more to add". E.g., I have eight
partitions for a topic, I now want
20 instead. It is more convenient to just say I want "20" partitions instead of
thinking of how many to add. OTOH since
we don't support reducing partitions treating it as a "num partitions to add"
is safer. So I don't feel very strongly
about it either way.
v2.2 - Re: unintentional reassignment of partitions. Yes you are right.
v2.3 - Your patch still has ZookeeperConsumerConnector changes in it, so it did
not apply cleanly.
v2.4 - On checking the replication factor: if we don't allow having a different
replication factor for the new partitions
we should not even expose it as an option.
v2.5 - AddPartitionsListener: no need to change it now, but just a comment: we
can directly parse the replica assignment
from the data object (instead of reading from zookeeper again) right?
v2.6 - On moving getManualReplicaAssignment to AdminUtils - I think it would be
good to do that here, but either way is
fine.
> change number of partitions of a topic online
> ---------------------------------------------
>
> Key: KAFKA-347
> URL: https://issues.apache.org/jira/browse/KAFKA-347
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Sriram Subramanian
> Labels: features
> Fix For: 0.8.1
>
> Attachments: kafka-347.patch, kafka-347-v2.patch
>
>
> We will need an admin tool to change the number of partitions of a topic
> online.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
