----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40726 -----------------------------------------------------------
Ship it! Looks good except for the minor issues below. core/src/main/scala/kafka/server/TopicConfigManager.scala <https://reviews.apache.org/r/20471/#comment73866> Since this is not currently exposed as a config should we just remove the parameter and inline it? core/src/main/scala/kafka/server/TopicConfigManager.scala <https://reviews.apache.org/r/20471/#comment73869> I think you intended to remove the .format (after removing the %d format specifier); or maybe log the entire change set? I think logging the list of changes would be useful. - Joel Koshy On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
