> On April 18, 2014, 1:17 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, line 62 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line62> > > > > Since this is not currently exposed as a config should we just remove > > the parameter and inline it?
I actually think it is helpful to call it out as a external value. I don't think we need to make it configurable, but maybe someday? > On April 18, 2014, 1:17 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, line 89 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line89> > > > > I think you intended to remove the .format (after removing the %d > > format specifier); or maybe log the entire change set? I think logging the > > list of changes would be useful. Ack, nice catch! Thanks! - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40726 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
