I don’t have a strong opinion on this. I am fine with running these tests nightly instead of on every merge to trunk.
On Wed 13. Sep 2023 at 08:13, Vaibhav Nazare <vaibhav.naz...@ibm.com.invalid> wrote: > Hi Colin, > I do agree with you on running a nightly job. > > Any thoughts on this Mickael and Divij so I can update the KIP accordingly? > > Thanks > Vaibhav Nazare > > > -----Original Message----- > From: Colin McCabe <cmcc...@apache.org> > Sent: Wednesday, September 13, 2023 3:48 AM > To: dev@kafka.apache.org > Subject: [EXTERNAL] Re: [VOTE] KIP-942: Add Power(ppc64le) support > > I just disagree with the idea of running it for every commit. If we can't > compromise on this condition then I just have to cast a -1. It's tough > enough to get stuff committed since our tests take quite a long time. The > fact that we only manage 5-6 commits a day is a bad thing, and not > something we should make even worse. It leads directly to things like big > PR backlogs, which we've discussed here many times. > > best, > Colin > > > On Mon, Sep 11, 2023, at 06:50, Vaibhav Nazare wrote: > > Hi Colin > > > > Can we continue the voting process now? > > > > Thanks > > Vaibhav Nazare > > > > -----Original Message----- > > From: Divij Vaidya <divijvaidy...@gmail.com> > > Sent: Monday, August 28, 2023 1:43 PM > > To: dev@kafka.apache.org > > Subject: [EXTERNAL] Re: [VOTE] KIP-942: Add Power(ppc64le) support > > > > Hey Colin > > > > I suggested running tests on every merge to trunk because on an > > average we have 5-6 commits merged per day in the discuss thread > > https://lists.apache.org/thread/4mfq46fc7nnsr96odqxxhcxyv24d8zn0 . > > Running this test suite 5 times won't be a burden to the CI > > infrastructure. The advantage we get is that, unlike nightly builds > > which have a chance of being ignored, branch builds are actively > > monitored by folks in the community. Hence, we will be able to add > > this new suite without adding a new routine in the maintenance. > > > > -- > > Divij Vaidya > > > > On Fri, Aug 25, 2023 at 6:49 PM Colin McCabe <cmcc...@apache.org> wrote: > >> > >> Thank you for continuing to work on this. > >> > >> One comment. When we discussed this in the DISCUSS thread, we all > wanted to run it nightly in branch builder (or possibly weekly). But > looking at the KIP, it doesn't seem to have been updated with the results > of these discussions. > >> > >> best, > >> Colin > >> > >> > >> On Mon, Aug 21, 2023, at 01:37, Mickael Maison wrote: > >> > +1 (binding) > >> > Thanks for the KIP! > >> > > >> > Mickael > >> > > >> > On Mon, Aug 14, 2023 at 1:40 PM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > >> >> > >> >> +1 (binding) > >> >> > >> >> -- > >> >> Divij Vaidya > >> >> > >> >> > >> >> On Wed, Jul 26, 2023 at 9:04 AM Vaibhav Nazare > >> >> <vaibhav.naz...@ibm.com.invalid> wrote: > >> >> > > >> >> > I'd like to call a vote on KIP-942 >