Thank you for making the change Christo. It looks good to me. -- Divij Vaidya
On Thu, Jan 11, 2024 at 11:19 AM Christo Lolov <christolo...@gmail.com> wrote: > Thank you Divij! > > I have updated the KIP to explicitly state that the broker will have a > different behaviour when a timestamp of -5 is requested as part of > ListOffsets. > > Best, > Christo > > On Tue, 2 Jan 2024 at 11:10, Divij Vaidya <divijvaidy...@gmail.com> wrote: > > > Thanks for the KIP Christo. > > > > The shell command that you mentioned calls ListOffsets API internally. > > Hence, I believe that we would be making a public interface change (and a > > version bump) to ListOffsetsAPI as well to include -5? If yes, can you > > please add that information to the change in public interfaces in the > KIP. > > > > -- > > Divij Vaidya > > > > > > > > On Tue, Nov 21, 2023 at 2:19 PM Christo Lolov <christolo...@gmail.com> > > wrote: > > > > > Heya! > > > > > > Thanks a lot for this. I have updated the KIP to include exposing the > > > tiered-offset as well. Let me know whether the Public Interfaces > section > > > needs more explanations regarding the changes needed to the OffsetSpec > or > > > others. > > > > > > Best, > > > Christo > > > > > > On Tue, 21 Nov 2023 at 04:20, Satish Duggana <satish.dugg...@gmail.com > > > > > wrote: > > > > > > > Thanks Christo for starting the discussion on the KIP. > > > > > > > > As mentioned in KAFKA-15857[1], the goal is to add new entries for > > > > local-log-start-offset and tierd-offset in OffsetSpec. This will be > > > > used in AdminClient APIs and also to be added as part of > > > > GetOffsetShell. This was also raised by Kamal in the earlier email. > > > > > > > > OffsetSpec related changes for these entries also need to be > mentioned > > > > as part of the PublicInterfaces section because these are exposed to > > > > users as public APIs through Admin#listOffsets() APIs[2, 3]. > > > > > > > > Please update the KIP with the above details. > > > > > > > > 1. https://issues.apache.org/jira/browse/KAFKA-15857 > > > > 2. > > > > > > > > > > https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java#L1238 > > > > 3. > > > > > > > > > > https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java#L1226 > > > > > > > > ~Satish. > > > > > > > > On Mon, 20 Nov 2023 at 18:35, Kamal Chandraprakash > > > > <kamal.chandraprak...@gmail.com> wrote: > > > > > > > > > > Hi Christo, > > > > > > > > > > Thanks for the KIP! > > > > > > > > > > Similar to the earliest-local-log offset, can we also expose the > > > > > highest-copied-remote-offset via > > > > > GetOffsetShell tool? This will be useful during the debugging > > session. > > > > > > > > > > > > > > > On Mon, Nov 20, 2023 at 5:38 PM Christo Lolov < > > christolo...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hello all! > > > > > > > > > > > > I would like to start a discussion for > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1005%3A+Add+EarliestLocalOffset+to+GetOffsetShell > > > > > > . > > > > > > > > > > > > A new offset called local log start offset was introduced as part > > of > > > > > > KIP-405: Kafka Tiered Storage. KIP-1005 aims to expose this > offset > > by > > > > > > changing the AdminClient and in particular the GetOffsetShell > tool. > > > > > > > > > > > > I am looking forward to your suggestions for improvement! > > > > > > > > > > > > Best, > > > > > > Christo > > > > > > > > > > > > > > > >
