Josep, past the deadline sorry but I can't see reasons not to cherry-pick this https://github.com/apache/kafka/pull/16326
On Wed, 12 Jun 2024 at 17:14, Josep Prat <josep.p...@aiven.io.invalid> wrote: > > Hi Edoardo, > > Correct, you can still cherry-pick this one. > > I'll send an email tomorrow morning (CEST) asking maintainers to stop > cherry picking commits unless we discuss it beforehand. > > Best, > > On Wed, Jun 12, 2024 at 6:09 PM Edoardo Comar <edoardli...@gmail.com> wrote: > > > Hi Josep, I understand I am still in time to cherry-pick on 3.8.0 > > https://github.com/apache/kafka/pull/16229 > > > > right? > > thanks > > > > On Wed, 12 Jun 2024 at 11:34, Ivan Yurchenko <i...@ivanyu.me> wrote: > > > > > > Hi, > > > > > > I'll try to do all the fixes and changes for KIP-899 [1] sooner today, > > but please proceed with the release if I don't manage. > > > > > > Ivan > > > > > > [1] https://github.com/apache/kafka/pull/13277 > > > > > > On Wed, Jun 12, 2024, at 12:54, Josep Prat wrote: > > > > Hi Luke, > > > > I think Jose, also mentioned that it won't be ready for v3.8.0 (but he > > can > > > > confirm this). My question now would be, given that it seems we would > > need > > > > a v3.9.0, do you think it's important to include > > > > https://github.com/apache/kafka/pull/16284 in v3.8.0? > > > > > > > > Best, > > > > > > > > On Wed, Jun 12, 2024 at 11:40 AM Luke Chen <show...@gmail.com> wrote: > > > > > > > > > Hi Josep > > > > > > > > > > For KIP-966, I think Calvin had mentioned he won't complete in > > v3.8.0. > > > > > https://lists.apache.org/thread/fsnr8wy5fznzfso7jgk90skgyo277fmw > > > > > > > > > > For unclean leader election, all we need is this PR: > > > > > https://github.com/apache/kafka/pull/16284 > > > > > For this PR, I think it needs one more week to be completed. > > > > > > > > > > Thanks. > > > > > Luke > > > > > > > > > > On Wed, Jun 12, 2024 at 4:51 PM Josep Prat > > <josep.p...@aiven.io.invalid> > > > > > wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > We are now really close to the planned code freeze deadline (today > > EOD). > > > > > > According to KIP-1012 [1] we agreed to stay in the 3.x branch > > until we > > > > > > achieve feature parity regarding Zookeeper and KRaft. The two main > > KIPs > > > > > > identified that would achieve this are: KIP-853 [2] and KIP-966 > > [3]. > > > > > > At the moment of writing this email both KIPs are not completed. My > > > > > > question to the people driving both KIPs would be, how much more > > time do > > > > > > you think it's needed to bring these KIPs to completion? > > > > > > > > > > > > - If the time needed would be short, we could still include these > > 2 KIPs > > > > > in > > > > > > the release. > > > > > > - However, if the time needed would be on the scale of weeks, we > > should > > > > > > continue with the release plan for 3.8 and after start working on > > the 3.9 > > > > > > release. > > > > > > > > > > > > What are your thoughts? > > > > > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1012%3A+The+need+for+a+Kafka+3.8.x+release > > > > > > [2]: > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-853%3A+KRaft+Controller+Membership+Changes > > > > > > [3]: > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-966%3A+Eligible+Leader+Replicas > > > > > > > > > > > > On Wed, Jun 12, 2024 at 10:40 AM Josep Prat <josep.p...@aiven.io> > > wrote: > > > > > > > > > > > > > Hi Rajini, > > > > > > > Yes, we could backport this one to the 3.8 branch. Would you be > > able to > > > > > > do > > > > > > > this once you merge this PR? > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > On Tue, Jun 11, 2024 at 10:53 PM Rajini Sivaram < > > > > > rajinisiva...@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> Hi Josep, > > > > > > >> > > > > > > >> The PR https://github.com/apache/kafka/pull/13277 for KIP-899 > > looks > > > > > > ready > > > > > > >> to be merged (waiting for the PR build).The PR changes several > > files, > > > > > > but > > > > > > >> is relatively straightforward and not risky. Also the changes > > are > > > > > under > > > > > > a > > > > > > >> config that is not enabled by default. Since the KIP was > > approved > > > > > before > > > > > > >> KIP freeze, will it be ok to include in 3.8.0? > > > > > > >> > > > > > > >> Thank you, > > > > > > >> > > > > > > >> Rajini > > > > > > >> > > > > > > >> > > > > > > >> On Tue, Jun 11, 2024 at 9:35 AM Josep Prat > > > > > <josep.p...@aiven.io.invalid > > > > > > > > > > > > > >> wrote: > > > > > > >> > > > > > > >> > Hi all, > > > > > > >> > > > > > > > >> > I just want to remind everybody that the code freeze deadline > > is > > > > > > >> > approaching. June 12th EOD is the deadline. > > > > > > >> > > > > > > > >> > Please do not automatically backport any commit to the 3.8 > > branch > > > > > > after > > > > > > >> > June 12th EOD. Ping me if you think the commit should be > > backported > > > > > > >> (fixes > > > > > > >> > failures in the branch or critical bug fixes). > > > > > > >> > > > > > > > >> > Thanks all! > > > > > > >> > > > > > > > >> > On Sat, Jun 1, 2024 at 8:43 PM José Armando García Sancio > > > > > > >> > <jsan...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > > >> > > Hi Josep, > > > > > > >> > > > > > > > > >> > > See my comments below. > > > > > > >> > > > > > > > > >> > > On Wed, May 29, 2024 at 10:52 AM Josep Prat > > > > > > >> <josep.p...@aiven.io.invalid > > > > > > >> > > > > > > > > >> > > wrote: > > > > > > >> > > > So I would propose to leave the deadlines as they are and > > > > > manually > > > > > > >> > cherry > > > > > > >> > > > pick the commits related to KIP-853 and KIP-966. > > > > > > >> > > > > > > > > >> > > Your proposal sounds good to me. I suspect that will be > > doing > > > > > > feature > > > > > > >> > > development for KIP-853 past the feature freeze and code > > freeze > > > > > > date. > > > > > > >> > > Maybe feature development will be finished around the end > > of June. > > > > > > >> > > > > > > > > >> > > I'll make sure to cherry pick commits for KIP-853 to the 3.8 > > > > > branch > > > > > > >> > > once we have one. > > > > > > >> > > > > > > > > >> > > Thanks, > > > > > > >> > > -- > > > > > > >> > > -José > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > -- > > > > > > >> > [image: Aiven] <https://www.aiven.io> > > > > > > >> > > > > > > > >> > *Josep Prat* > > > > > > >> > Open Source Engineering Director, *Aiven* > > > > > > >> > josep.p...@aiven.io | +491715557497 > > > > > > >> > aiven.io <https://www.aiven.io> | < > > > > > > >> https://www.facebook.com/aivencloud > > > > > > >> > > > > > > > > >> > <https://www.linkedin.com/company/aiven/> < > > > > > > >> > https://twitter.com/aiven_io> > > > > > > >> > *Aiven Deutschland GmbH* > > > > > > >> > Alexanderufer 3-7, 10117 Berlin > > > > > > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > >> > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > [image: Aiven] <https://www.aiven.io> > > > > > > > > > > > > > > *Josep Prat* > > > > > > > Open Source Engineering Director, *Aiven* > > > > > > > josep.p...@aiven.io | +491715557497 > > > > > > > aiven.io <https://www.aiven.io> | > > > > > > > <https://www.facebook.com/aivencloud> > > > > > > > <https://www.linkedin.com/company/aiven/> < > > > > > > https://twitter.com/aiven_io> > > > > > > > *Aiven Deutschland GmbH* > > > > > > > Alexanderufer 3-7, 10117 Berlin > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > [image: Aiven] <https://www.aiven.io> > > > > > > > > > > > > *Josep Prat* > > > > > > Open Source Engineering Director, *Aiven* > > > > > > josep.p...@aiven.io | +491715557497 > > > > > > aiven.io <https://www.aiven.io> | < > > > > > https://www.facebook.com/aivencloud > > > > > > > > > > > > > <https://www.linkedin.com/company/aiven/> < > > > > > > https://twitter.com/aiven_io> > > > > > > *Aiven Deutschland GmbH* > > > > > > Alexanderufer 3-7, 10117 Berlin > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > > > > > > > > > > > > -- > > > > [image: Aiven] <https://www.aiven.io> > > > > > > > > *Josep Prat* > > > > Open Source Engineering Director, *Aiven* > > > > josep.p...@aiven.io | +491715557497 > > > > aiven.io <https://www.aiven.io> | < > > https://www.facebook.com/aivencloud> > > > > <https://www.linkedin.com/company/aiven/> < > > https://twitter.com/aiven_io> > > > > *Aiven Deutschland GmbH* > > > > Alexanderufer 3-7, 10117 Berlin > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > -- > [image: Aiven] <https://www.aiven.io> > > *Josep Prat* > Open Source Engineering Director, *Aiven* > josep.p...@aiven.io | +491715557497 > aiven.io <https://www.aiven.io> | <https://www.facebook.com/aivencloud> > <https://www.linkedin.com/company/aiven/> <https://twitter.com/aiven_io> > *Aiven Deutschland GmbH* > Alexanderufer 3-7, 10117 Berlin > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > Amtsgericht Charlottenburg, HRB 209739 B
