[ 
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357348#comment-14357348
 ] 

Guozhang Wang commented on KAFKA-1910:
--------------------------------------

Found the root cause: in handling ListOffsetReponse in the new consumer, we 
assume the possible error are NOT_LEADER_FOR_PARTITION and 
LEADER_NOT_AVAILABLE, and if there are other error codes we just use

{code}
Errors.forCode(errorCode).maybeThrow()
{code}

Which by the way does not print any stack trace in unit tests, hence very 
difficult to debug.

The proposed patch fixed this issue, in addition, I think this is another 
example that calls out for KAFKA-1985.

> Refactor KafkaConsumer
> ----------------------
>
>                 Key: KAFKA-1910
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1910
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: consumer
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>         Attachments: KAFKA-1910.patch, KAFKA-1910_2015-03-05_14:55:33.patch
>
>
> KafkaConsumer now contains all the logic on the consumer side, making it a 
> very huge class file, better re-factoring it to have multiple layers on top 
> of KafkaClient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to