[ 
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387652#comment-14387652
 ] 

Joel Koshy commented on KAFKA-1910:
-----------------------------------

[~guozhang] this patch modified some of the behavior of OffsetFetchRequest 
which [~toddpalino] caught while using a python client against the latest 
broker (on trunk)

Previously, we would return NoError with an invalid offset if there was no 
committed offset. Now it returns the NoOffsetsCommittedCode. Was there a 
discussion on this? Either way, we should also update the protocol 
documentation if this change sticks.

> Refactor KafkaConsumer
> ----------------------
>
>                 Key: KAFKA-1910
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1910
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: consumer
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1910.patch, KAFKA-1910.patch, 
> KAFKA-1910_2015-03-05_14:55:33.patch
>
>
> KafkaConsumer now contains all the logic on the consumer side, making it a 
> very huge class file, better re-factoring it to have multiple layers on top 
> of KafkaClient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to