[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482084#comment-14482084
]
Guozhang Wang commented on KAFKA-1910:
--------------------------------------
[~jjkoshy]:
1. No the error code change was not necessary, I originally just add it for
OffsetCommitTest, hence it only checks NoError code for the case where no
offsets is fetchable.
2. This change has been reverted (by accident while doing rebase) in
KAFKA-1634, I can submit a follow-up patch to delete the exception class and
the error code from mapping.
> Refactor KafkaConsumer
> ----------------------
>
> Key: KAFKA-1910
> URL: https://issues.apache.org/jira/browse/KAFKA-1910
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Fix For: 0.8.3
>
> Attachments: KAFKA-1910.patch, KAFKA-1910.patch,
> KAFKA-1910_2015-03-05_14:55:33.patch
>
>
> KafkaConsumer now contains all the logic on the consumer side, making it a
> very huge class file, better re-factoring it to have multiple layers on top
> of KafkaClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
