Looking at modifyConfigs API, it doesn't seem that ConcurrentHashMap should be used as the underlying parameter type.
Anyway, to signify that null value is supported, value type can be declared as Optional<Config>. FYI On Fri, Jul 13, 2018 at 5:35 PM Colin McCabe <cmcc...@apache.org> wrote: > Hi Ted, > > That’s a fair question. I think the main reason I didn’t propose that > originally is that many people find null values in maps confusing. Also, > some newer java maps don’t support null values, such as ConcuurentHashMap. > I’m curious what others think about this. > > Best, > Colin > > On Wed, Jul 11, 2018, at 21:28, Ted Yu wrote: > > bq. Map<ConfigResource, Config> changes, Set<ConfigResource> > removals, > > > > Is it possible to combine the two parameters into one Map where null > Config > > value signifies removal of config ? > > This way, the following wouldn't occur (reducing un-intended config > > removal): > > > > bq. If a configuration key is specified in both *changes* and *removals* > > > > *Cheers* > > > > On Wed, Jul 11, 2018 at 10:54 AM Colin McCabe <cmcc...@apache.org> > wrote: > > > > > Hi all, > > > > > > Previously, we discussed some issues with alterConfigs here on the > mailing > > > list, and eventually came to the conclusion that the RPC as implemented > > > can't be used for a shell command modifying configurations. > > > > > > I wrote up a small KIP to fix the issues with the RPC. Please take a > look > > > at > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-339%3A+Create+a+new+ModifyConfigs+API > > > > > > best, > > > Colin > > > > >
