Dan Burkert has posted comments on this change. Change subject: C++11: Simplify thirdparty TSAN build ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1763/2/cmake_modules/FindBitshuffle.cmake File cmake_modules/FindBitshuffle.cmake: Line 9: NO_CMAKE_SYSTEM_PATH > I actually think that NO_DEFAULT_PATH is too broad, and NO_CMAKE_SYSTEM_PAT I think I would have had to change all of the Find*.cmake files anyway to do that. In my opinion the new format is simpler and more in line with how CMake expects things to be done. Also the error messages are better when libraries are missing. -- To view, visit http://gerrit.cloudera.org:8080/1763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9824db19383556da88053779bdde1e66cdfa44 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
