Adar Dembo has posted comments on this change. Change subject: C++11: Simplify thirdparty TSAN build ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1763/2/cmake_modules/FindBitshuffle.cmake File cmake_modules/FindBitshuffle.cmake: Line 9: NO_CMAKE_SYSTEM_PATH > I think I would have had to change all of the Find*.cmake files anyway to d I think this boils down to, in the event of a malformed thirdparty tree (i.e. partially downloaded, partially installed, etc.), whether the build ought to "fall back" to some other libraries, or whether it should fail. It's largely a moot point as the thirdparty tree is supposed to be intact, and it's largely philosophical. I personally prefer hard failure if we don't find exactly what we expect in thirdparty, but I guess I don't feel strongly about it. I did verify in the docs that CMAKE_PREFIX_PATH takes precedence in the search over PATH. http://gerrit.cloudera.org:8080/#/c/1763/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 29: # > I can't really elaborate beyond "dependency x does not require additional l Well, EXTRA_* include things like user-specified LDFLAGS, CXXFLAGS, etc. Which is why I'm surprised they're not passed into every single dependency build. -- To view, visit http://gerrit.cloudera.org:8080/1763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9824db19383556da88053779bdde1e66cdfa44 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
