Dan Burkert has posted comments on this change. Change subject: C++11: Simplify thirdparty TSAN build ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1763/2/cmake_modules/FindBitshuffle.cmake File cmake_modules/FindBitshuffle.cmake: Line 9: NO_CMAKE_SYSTEM_PATH > I think this boils down to, in the event of a malformed thirdparty tree (i. I've added the additional environment exclusion in the latest patchset. http://gerrit.cloudera.org:8080/#/c/1763/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 29: # > Well, EXTRA_* include things like user-specified LDFLAGS, CXXFLAGS, etc. Wh I don't have a great reason that every dependency doesn't have the flags set, except that they don't need to be to get stuff working, and I'm not 100% convinced that setting these flags (even to the empty string) doesn't alter configure scripts, so I don't want to add them unnecessarily. -- To view, visit http://gerrit.cloudera.org:8080/1763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9824db19383556da88053779bdde1e66cdfa44 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
