Adar Dembo has posted comments on this change. Change subject: C++11: Simplify thirdparty TSAN build ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1763/4/cmake_modules/FindBitshuffle.cmake File cmake_modules/FindBitshuffle.cmake: Line 9: NO_CMAKE_SYSTEM_PATH NO_SYSTEM_ENVIRONMENT_PATH Nit: would you mind reformatting these guys? find_path(VAR something NO_CMAKE_SYSTEM_PATH NO_SYSTEM_ENVIRONMENT_PATH) I think that's easier to read. Same for find_library(). -- To view, visit http://gerrit.cloudera.org:8080/1763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9824db19383556da88053779bdde1e66cdfa44 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
