Jean-Daniel Cryans has posted comments on this change. Change subject: Send back an error when UpdateConsensus cannot prepare a single transaction ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1785/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1138: FillConsensusResponseError(response, ConsensusErrorPB::INVALID_TERM, > INVALID_TERM doesn't seem like the right error code Mmm right, I'm abusing it, but I don't see another one that fits. CONSENSUS_BUSY? New one? Line 1139: Status::IllegalState(msg)); > IllegalState seems like an odd choice for status... Well it's in a state that doesn't permit accepting UpdateConsensus calls. Without the return we still do the right thing, it's basically treated as if we had de-duped everything. On one hand a return in the middle of the function isn't nice, otoh there's a change relying on some behavior might break us in the future. I'll call FillConsensusResponseOKUnlocked and return. -- To view, visit http://gerrit.cloudera.org:8080/1785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546fd3069af974383c23acb7406ea621e6962bb3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
