Jean-Daniel Cryans has posted comments on this change. Change subject: Send back an error when UpdateConsensus cannot prepare a single transaction ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1785/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1138: FillConsensusResponseError(response, ConsensusErrorPB::INVALID_TERM, > Yes, we should only use INVALID_TERM for precisely that error. Creating a n > Yea I'd say a new one like CANNOT_PREPARE or something? do we know the > typical reason why this would happen? I only know of the case I saw where we were trying to change the raft config and for some reason (which I'm trying to discover with this patch) we are either unable to do it or just taking too much time. Line 1139: Status::IllegalState(msg)); > maybe we should pass through the prepare_status? that's the thing likely to Will add as part of the message. -- To view, visit http://gerrit.cloudera.org:8080/1785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546fd3069af974383c23acb7406ea621e6962bb3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
