Adar Dembo has posted comments on this change. Change subject: [c++-client] abstract scanner configuration ......................................................................
Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/2726/2//COMMIT_MSG Commit Message: Line 13: used internally in the forthecoming scan token builder API. Nit: forthcoming http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scan_configuration.cc File src/kudu/client/scan_configuration.cc: Line 148: //if (!tight_enum_test<ReadMode>(read_mode)) { What happened here? http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scan_configuration.h File src/kudu/client/scan_configuration.h: Line 42: explicit ScanConfiguration(KuduTable* table); The ScanConfiguration must out-live the KuduTable, right? Line 49: Status AddConjunctPredicate(KuduPredicate* pred) WARN_UNUSED_RESULT; Takes ownership? Line 55: Status AddLowerBoundRaw(const Slice& key); These four functions (the ones that take Slices) make copies, right? Line 107: ScanSpec& mutable_spec() { Should return a pointer here. In mutable_scan_spec() too. Line 143: KuduTable* table_; Non-owned, right? Can you annotate as such? Line 166: Arena arena_; Should comment on what allocations are made here, and what gets attached to the pool_. http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 52: static const int64_t kNoTimestamp = -1; Could we reuse the definition in ScanConfiguration? http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: Line 153: ScanConfiguration& mutable_configuration() { Isn't it more typical in Kudu for mutable_foo() to return a pointer? -- To view, visit http://gerrit.cloudera.org:8080/2726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
