Dan Burkert has posted comments on this change. Change subject: [c++-client] abstract scanner configuration ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scan_configuration.h File src/kudu/client/scan_configuration.h: Line 49: Status AddConjunctPredicate(KuduPredicate* pred) WARN_UNUSED_RESULT; > I should have been more clear. I was asking a question, but I was hoping to as we discussed, the individual method comments match the corresponding methods on KuduScanner. -- To view, visit http://gerrit.cloudera.org:8080/2726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
