Dan Burkert has posted comments on this change. Change subject: [c++-client] abstract scanner configuration ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2726/3/src/kudu/client/scan_configuration.h File src/kudu/client/scan_configuration.h: Line 32: // A configuration object which holds Kudu scan options. > is this intended to become a public API in a later patch? No, not as it's written currently. The goal was to move the implementation for scan configuration from KuduScanner::Data to this class so that it could be shared between KuduScanner and the upcoming scan token builder. I'm +1 on adding a ScannerBuilder class to the c++ client, and this class could be a starting point, but it would probably have to change a bit. I didn't want to go down that particular rabbit hole as part of the scan tokens work, though. -- To view, visit http://gerrit.cloudera.org:8080/2726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
