Adar Dembo has posted comments on this change. Change subject: [c++-client] abstract scanner configuration ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2726/2/src/kudu/client/scan_configuration.h File src/kudu/client/scan_configuration.h: Line 42: explicit ScanConfiguration(KuduTable* table); > No, the KuduTable must outlive the ScanConfiguration. Oops, I meant the other way around. Line 49: Status AddConjunctPredicate(KuduPredicate* pred) WARN_UNUSED_RESULT; > correct. I should have been more clear. I was asking a question, but I was hoping to take my answer in the form of a code comment. :) That's true for the rest of the comments I left here. -- To view, visit http://gerrit.cloudera.org:8080/2726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
