----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37934/#review97395 -----------------------------------------------------------
- Why are parameterization and saved query are combined into one entity? I think parameterization should be separate and even simple queries can use them. - Do we have any expiry on saved queries? - Can we put up differences between prepared queries and saved queries clearly? - Can we put up differences between set param available on session and parameterization that is getting added in this change? lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java (line 35) <https://reviews.apache.org/r/37934/#comment153284> We have SYNTAX_ERROR sitting in LensCubeErrorCode, may be that should be moved here, instead of creating a new one. lens-api/src/main/resources/lens-errors.conf (line 52) <https://reviews.apache.org/r/37934/#comment153285> Can we parameterize this passing the resource? lens-api/src/main/resources/lens-errors.conf (line 64) <https://reviews.apache.org/r/37934/#comment153286> we should use Syntax error already defined - which gives details on syntax error as well. lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java (line 27) <https://reviews.apache.org/r/37934/#comment153287> Please extend from LensException and associate an Error code and error message in lens-errors.conf lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java (line 28) <https://reviews.apache.org/r/37934/#comment153288> Same as above lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 82) <https://reviews.apache.org/r/37934/#comment153289> Importing LensException would reduce code. lens-server/src/main/resources/lensserver-default.xml (line 769) <https://reviews.apache.org/r/37934/#comment153290> Does it need to have a separate db url? Using lensserver db itself would be good? - Amareshwari Sriramadasu On Aug. 30, 2015, 7:25 p.m., Amruth Sampath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 7:25 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > > > Repository: lens > > > Description > ------- > > Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742 > (Note : Sharing and CLI are not a part of this patch) > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java > 754e6e1 > lens-api/src/main/resources/lens-errors.conf 3fb191e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ResourceNotFoundException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5d33eda > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml 4cf94d5 > > Diff: https://reviews.apache.org/r/37934/diff/ > > > Testing > ------- > > Have added unit test cases for parsing, resolution of parameter and service > testing. > > > Thanks, > > Amruth Sampath > >
