-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 8:49 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat
Khandelwal, and sharad agarwal.
Changes
-------
1) Moving api classes to lens-api
2) Restructuring rest apis
3) Added javadoc to all API and service classes
4) Other refactorings pointed out in the review
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java
754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java
PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
0dfd7da
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
720825a
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java
5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
2189eb8
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service
testing.
Thanks,
Amruth Sampath
