> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/lens-errors.conf, line 58
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064148#file1064148line58>
> >
> > Should user name also go in error message?
> >
> > Will "%s access" say admin/read/write access ?
> >
> > What is %s:%s ? Should that be single param %s ?
The format is
User does not have {priv} access to {resource_type}:{resource_identifier}
priv -> create/read/write/delete
resource_type -> saved_query/schedule etc
resource_identifier -> id of the resource.
I thought user name wont be needed as the exception is anyways returned to the
concerned users.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java,
> > line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it
> > should be lens-api package.
The ParameterDataType and ParameterCollectionType throws some exceptions which
are extending from LensException (so that error code mapping is done
automatically).
Moving this to lens-api would mean LensException is not vissible anymore.
Should I rather create wrapper around these exceptions @ lens-server-api?
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java,
> > line 264
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064170#file1064170line264>
> >
> > what is this Result handler for? Can you add comments?
Sure. This was for getting the last inserted id from the saved queries table
(Needed when an creates a saved query. ID has to be sent back as a response).
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/resources/lens-site.xml, lines 141-152
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064177#file1064177line141>
> >
> > Need to be removed?
yes.. Will remove it:)
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java,
> > line 53
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064171#file1064171line53>
> >
> > should we have this under queryapi/ itself?
> >
> > I'm thinking 'yes'. What do you think?
> >
> > Making this path /queryapi will cause any issue with other query
> > resource? I'm hoping it should not, not sure though.
Yes it will work. We just have to ensure that there are no ambiguity in the
paths. I have tested it now.
I also think it makes more sense under queryapi/. Ill make the changes.
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat
> Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java
> 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
> 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
> PRE-CREATION
>
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
> PRE-CREATION
>
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java
> PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java
> 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
>
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
> 2189eb8
>
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
> PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service
> testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
