> On Sept. 2, 2015, 4:20 a.m., Amareshwari Sriramadasu wrote: > > - Why are parameterization and saved query are combined into one entity? I > > think parameterization should be separate and even simple queries can use > > them. > > - Do we have any expiry on saved queries? > > - Can we put up differences between prepared queries and saved queries > > clearly? > > - Can we put up differences between set param available on session and > > parameterization that is getting added in this change?
Why are parameterization and saved query are combined into one entity? I think parameterization should be separate and even simple queries can use them. SavedQuery is just encapsulating Parameters. These parameters could be used with the normal on the fly queries also. But it would not make sense as an use case because if an user is going to run a parameterized query providing bind values on the fly, he might as well just provide a static query. Do we have any expiry on saved queries? Saved queries cannot be expired. They are more like an user generated resource Can we put up differences between prepared queries and saved queries clearly? The description in jira explains the complete use case of saved queries. Also I have added a comment that distinguishes saved query from prepared queries. https://issues.apache.org/jira/browse/LENS-742 Can we put up differences between set param available on session and parameterization that is getting added in this change? This setParam available in session is for setting session level parameters that could be used under any context. The parameterization available here is completely different. Say we have a query that is saved like this - "select col1 from table where col1 = :param" (param is a bind parameter) The query would be run with through an API like this - /savedquery/4/run?param="value" (Essentially the user is running the saved query with id 4 supplying values for whatever parameter he has specified while creating it) - Amruth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37934/#review97395 ----------------------------------------------------------- On Aug. 30, 2015, 7:25 p.m., Amruth Sampath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 7:25 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > > > Repository: lens > > > Description > ------- > > Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742 > (Note : Sharing and CLI are not a part of this patch) > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java > 754e6e1 > lens-api/src/main/resources/lens-errors.conf 3fb191e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ResourceNotFoundException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 5d33eda > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml 4cf94d5 > > Diff: https://reviews.apache.org/r/37934/diff/ > > > Testing > ------- > > Have added unit test cases for parsing, resolution of parameter and service > testing. > > > Thanks, > > Amruth Sampath > >