> On Sept. 26, 2016, 12:44 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 29 > > <https://reviews.apache.org/r/52259/diff/1/?file=1510017#file1510017line29> > > > > Can you add documentation? e.g. What is the key `String` and what is > > supposed to be in the map.
Added the Documentation. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150390 ----------------------------------------------------------- On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52259/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 1:03 p.m.) > > > Review request for lens. > > > Bugs: LENS-1340 > https://issues.apache.org/jira/browse/LENS-1340 > > > Repository: lens > > > Description > ------- > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52259/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
