> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 35 > > <https://reviews.apache.org/r/52259/diff/3/?file=1511766#file1511766line35> > > > > Will it be measure names here or measure tags?
Will use measure tags for it. > On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 34 > > <https://reviews.apache.org/r/52259/diff/3/?file=1511766#file1511766line34> > > > > Mention end date is exclusive Will add this in the comment. > On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 32 > > <https://reviews.apache.org/r/52259/diff/3/?file=1511766#file1511766line32> > > > > Give more details about what does tag mean here. Added description for the fact tag. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150811 ----------------------------------------------------------- On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52259/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-1340 > https://issues.apache.org/jira/browse/LENS-1340 > > > Repository: lens > > > Description > ------- > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52259/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
