----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150396 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java (line 32) <https://reviews.apache.org/r/52259/#comment218368> What interval are the keys in the map spaced over? Perhaps we need an UpdatePeriod argument? Also, do keep in mind that end date should be exclusive. And, if we are passing start, end and UpdatePeriod, it might be better to use `org.apache.lens.cube.metadata.TimePartitionRange` - Rajat Khandelwal On Sept. 26, 2016, 6:33 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52259/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 6:33 p.m.) > > > Review request for lens. > > > Bugs: LENS-1340 > https://issues.apache.org/jira/browse/LENS-1340 > > > Repository: lens > > > Description > ------- > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52259/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
