----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150811 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java (line 32) <https://reviews.apache.org/r/52259/#comment218876> Give more details about what does tag mean here. lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java (line 34) <https://reviews.apache.org/r/52259/#comment218877> Mention end date is exclusive lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java (line 35) <https://reviews.apache.org/r/52259/#comment218878> Will it be measure names here or measure tags? lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java (line 38) <https://reviews.apache.org/r/52259/#comment218879> Should start and end dates be string to accept relative ranges like now.day-2days and etc ? If so, we should fix the format for passing date fields as string. - Amareshwari Sriramadasu On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52259/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-1340 > https://issues.apache.org/jira/browse/LENS-1340 > > > Repository: lens > > > Description > ------- > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52259/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
